You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working with numerics in num-traits is biased towards using the standard traits, which is generally good. However, checked arithmetic is lacking a unifying trait (like NumOps). This PR adds that.
This trait should theoretically be a supertrait of PrimInt. However, this trait (like NumOps: Rem), requires CheckedRem. PrimInt does not currently require that, meaning that this would be a breaking change. (PrimInt: CheckedNumOps for a future release?)
This trait should theoretically be a supertrait of PrimInt. However, this trait (like NumOps: Rem), requires CheckedRem. PrimInt does not currently require that, meaning that this would be a breaking change. (PrimInt: CheckedNumOps for a future release?)
I think it's just that CheckedRem didn't exist at the time. Yes, it would make sense, but also yes, it would be a breaking change.
You did not actually include CheckedNumOps: CheckedRem though -- did you mean to?
I wrote all that out about it and forgot to actually require CheckedRem. I think my idea was that I'm not sure what should happen with it. CheckedNumOps could not require CheckedRem and be a supertrait of PrimInt, or it could require CheckedRem and be disconnected from PrimInt. I wasn't sure on the best course of action, so I think that's why I left CheckedRem out.
However, now I think that using CheckedRem is the right way to go. If you don't think so you can roll back the most recent commit to the fork, which actually adds CheckedRem.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with numerics in
num-traitsis biased towards using the standard traits, which is generally good. However, checked arithmetic is lacking a unifying trait (likeNumOps). This PR adds that.This trait should theoretically be a supertrait of
PrimInt. However, this trait (likeNumOps: Rem), requiresCheckedRem.PrimIntdoes not currently require that, meaning that this would be a breaking change. (PrimInt: CheckedNumOpsfor a future release?)